fix timebase processing in frd, zpk #1064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slivingston
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #1062 by making sure that timebases are handled uniformly in all system creation factory functions:
ss,tf,frd, andzpk, use either an additional argument specifying the sampling time or use thedtkeyword (using both generates a warning).nlsys, use thedtkeywordconfig.defaults['control.default_dt'], which is 0 (continuous time) unless you change it.It was the last of these that was the problem in
zpk: it was defaulting toNoneand that was later interpreted as a discrete time system.Also added unit tests to make sure everything is consistent across the different factory functions.