-
Notifications
You must be signed in to change notification settings - Fork 439
Add combine()
and split()
functions for transfer matrices
#1073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
62d6f83
Add combine and split functions
sdahdah 8ac3adc
Remove pass typo
sdahdah 758fa9d
Add test and fix for mismatched row outputs
sdahdah 120984f
Update documentation for exception
sdahdah 76d4ee7
Add input dimension check
sdahdah 9f4bf4f
Rename split and combine to split_tf and combine_tf
sdahdah dc36574
Adjust naming and docstring conventions
sdahdah 1cbd6b3
Add example with NumPy arrays
sdahdah 68d52d8
Fix line length
sdahdah 35fa5b3
Fix line length in test file
sdahdah 8bc9487
Remove extra markup
sdahdah 1cc84a7
Add extra test case for wrong number of inputs
sdahdah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dt
will always exist for anInputOutputSystem
, so this can just betfn.dt
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
combine_tf()
function allows NumPy arrays to be input as well, so you can do something likeSo in that case, the NumPy arrays do not have a
dt
attribute. Thedt
will be taken from theTransferFunction
object in this case.I've found this useful when creating weighting functions for optimal control problems.