Fix color cycling not working in singular_values_plot #1138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this seems to have ben caused by a name collision between the function scope color variable and the loop-"local" color variable. the first time _get_color is called it will replace the function level color so in the next iteration a color is explicitly passed to _get_color so it will no longer automatically cycle through colors.
|
And I guess the broken CI checks will also fail for this one... |
|
Thanks @lkies. We should also add a unit test to catch the issue and verify it is fixed. You can find one here: murrayrm@904516f |
|
@murrayrm No problem, I added your test, but why not just merge your own changes? |
|
I was waiting until we fixed the CI error before generating the PR, but since you had done the fix in parallel, definitely fine to use yours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to have been caused by a name collision between the function scope
colorvariable and the loop-"local"colorvariable. The first time_get_coloris called it will replace the function levelcolorso in the next iteration a colorspec is explicitly passed to_get_colorso it will no longer automatically cycle through colors.Closes #1134