Skip to content

fix ax processing bug in {nyquist,nichols,describing_function}_plot #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2025
Merged

fix ax processing bug in {nyquist,nichols,describing_function}_plot #1145

merged 2 commits into from
Apr 17, 2025

Conversation

murrayrm
Copy link
Member

This PR fixes #1144 (also pointed out in #1143) where the ax keyword was being ignored in the nyquist_plot command.

Turns out that there were several related bugs:

  • The Nichols grid was not being plotted in the proper location when ax was passed to nichols_plot.
  • The describing function curve was not being plotted in the proper location when ax was passed to describing_funciton_plot.

This PR fixes those bugs as well, and includes an updated unit test that picks up all three previous errors.

@coveralls
Copy link

Coverage Status

coverage: 94.746% (-0.001%) from 94.747%
when pulling 21f4912 on murrayrm:fix_nyquist_ax-16Apr2025
into dc7d71b on python-control:main.

@slivingston slivingston self-requested a review April 17, 2025 19:49
@slivingston slivingston merged commit 632391c into python-control:main Apr 17, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slivingston slivingston Awaiting requested review from slivingston

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nyquist plot uses incorrect subplot axes
3 participants
@murrayrm @coveralls @slivingston