OS/BLAS update for Windows + small fixes for 0.10.2 release #1164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the OS/BLAS test matrix, where the Windows test was failing. The problem seems to be that the
slycotconda recipe is not working under the current runners (nmakeis not installed by default). Since buildingslycotfrom scratch is not that common on Windows, I change the code so thatslycotis grabbed from conda-forge on the Window runner, but is still included in the test matrix.In addition, this PR has some small documentation and unit test fixes to get rid of warnings that were discovered as part of the release progress. I also updated the license variable in
pyproject.tomlto match the new Python Packaging User Guide specification (string instead of a table).This should be the final set of changes required for 0.10.2. I'll start working on the actual release in the coming day or two.