Skip to content

DOC: fixed additional small typo in installation docs #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 1, 2017

Conversation

murrayrm
Copy link
Member

Forgot to push a local documentation change. This PR fixes a small error in the conda installation instructions and also adds a command to make sure numpy, scipy and matplotlib are installed (all pre-requisites).

@coveralls
Copy link

coveralls commented Dec 31, 2016

Coverage Status

Coverage remained the same at 77.324% when pulling 3bfd2be on murrayrm:doc-update into 99cc2e9 on python-control:master.

@coveralls
Copy link

coveralls commented Dec 31, 2016

Coverage Status

Coverage decreased (-0.2%) to 77.135% when pulling c387c69 on murrayrm:doc-update into 99cc2e9 on python-control:master.

@slivingston
Copy link
Member

slivingston commented Jan 1, 2017

Good catch of the error in the conda install command! I missed it while reviewing #123.

If it is a working Anaconda installation, it should already have numpy, scipy, and matplotlib, as listed at https://docs.continuum.io/anaconda/pkg-docs.html. Nonetheless an extra conda install numpy scipy matplotlib should not cause trouble.

@@ -59,9 +59,10 @@ and verifying that no error message appears. It may be necessary to install
from the `slycot project page <https://github.com/python-control/Slycot>`_.

For users with a working the Anaconda distribution of Python, the following
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be "...with the Anaconda distribution..."?

(copied from #123 (comment); still relevant here)

@slivingston
Copy link
Member

The CI test failures are caused by 500 response codes from requests to repo.continuum.io. I get the same response when I attempt conda install -c python-control -c cyclus slycot control from my own local host, so likely an error on the (Continuum) server side.

@slivingston slivingston merged commit 32f13bc into python-control:master Jan 1, 2017
@murrayrm murrayrm deleted the doc-update branch January 5, 2017 06:53
@murrayrm murrayrm added this to the 0.8.0 milestone Dec 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants