SISO tf() may not work with numpy arrays with numpy.int elements. #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this discussion seem related? numpy/numpy#2951 |
|
@roryyorke Thanks for your comments. @jed-frey Hope this helps. Also found this QnA. |
|
Different parts of this PR are covered by other PR's:
There is some unit test code there that it would be good to merge. I will try to take care of that in the coming days. |
|
The changes in this PR have been incorporated into PR #135. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SISO tf() function may not work if an input argument is numpy.int.
(@sunhapos could identify this)
Please check the test for cases.
Should this be a numpy issue? If so, is a quick patch such as 3fe4067 desirable?
Thanks,
KW