Bode margins plot #199
Merged
Bode margins plot #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build seems to be failing due to issue #194 |
|
I don't see what the
line is for. Seems not to be used, and renaming it system is not a good idea in this context |
|
@repagh , you are right. I suspect this was a leftover from some testing on my part. I removed it. |
|
Note: this PR has been included in PR #209. If that PR is merged, can delete this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added display of the phase and gain margins to the bode plots in order to emulate matlab like functionality when calling margin(sys) in matlab. Can be used when calling bode(sys, margins=True). Attached 2 screenshots showing the plots in matplotlib and matlab side by side.