Skip to content

update minreal unit test to use poles/zeros instead of num/den #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2018

Conversation

murrayrm
Copy link
Member

@murrayrm murrayrm commented Jul 7, 2018

This PR fixes issue #217 by using a better test to see if minreal() is operating correctly: instead of checking whether transfer functions are the same, we check whether poles and zeros are the same. (This avoids some simplifications than can happen in the transformation of state space objects to transfer function objects.)

@coveralls
Copy link

coveralls commented Jul 7, 2018

Coverage Status

Coverage remained the same at 78.914% when pulling 99de25a on murrayrm:fix_minreal_test into cab7fa0 on python-control:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.914% when pulling 99de25a on murrayrm:fix_minreal_test into cab7fa0 on python-control:master.

@murrayrm murrayrm merged commit 11bf14c into python-control:master Jul 7, 2018
@murrayrm murrayrm mentioned this pull request Jul 7, 2018
@murrayrm murrayrm deleted the fix_minreal_test branch July 7, 2018 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants