Skip to content

Fix pzmap not showing zeroes #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix pzmap not showing zeroes #230

wants to merge 1 commit into from

Conversation

geez0x1
Copy link

@geez0x1 geez0x1 commented Jul 27, 2018 •
edited
Loading

pzmap does not show the transfer function's zeroes, as the internal plotting argument has facecolors='none':

   if len(zeros) > 0:
        plt.scatter(real(zeros), imag(zeros), s=50, marker='o',
                    facecolors='none')

Removing this argument solves the issue.

@geez0x1
Copy link
Author

geez0x1 commented Jul 27, 2018 •
edited
Loading

Demonstration of the fix:

screenshot from 2018-07-27 17-12-02

@coveralls
Copy link

coveralls commented Jul 27, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 78.914% when pulling 278524e on geez0x1:master into a007fcc on python-control:master.

@murrayrm
Copy link
Member

This is also addressed in PR #193, which is waiting on some changes before being merged. Need to reconcile any differences.

@murrayrm murrayrm added this to the 0.8.2 milestone Jul 27, 2018
@geez0x1
Copy link
Author

geez0x1 commented Jul 27, 2018

Ah, sorry about that, I tried searching for an issue referencing pzmap but couldn't find it. Thanks!

@murrayrm
Copy link
Member

Fixed in PR #193.

@murrayrm murrayrm closed this Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.2
Development

Successfully merging this pull request may close these issues.
3 participants
@geez0x1 @coveralls @murrayrm