Make all examples Python 3 compatible #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reimplemented mlab.find as private _find. Replaced mlab.frange calls with equivalent numpy.linspace call, and corrected phaseplot.phase_plot docs for how the X and Y arguments are used.
Added titles, removed all show calls except last.
tfvis.py uses Tkinter, and won't work as-is in Python 3.
Uses Python 3 tkinter module name; the future package lets this work in Python 2 as well.
|
@roryyorke I get a failure on Travis CI on this PR. When I pulled to my local account and then pushed to my personal repository, I got the error "Could not parse .travis.yml". I think this is why there is no Travis CI info above. |
|
Where do you see the error? I'm getting no Travis builds at all, but can't see why. I thought maybe it was the webhook problem, though I see that only kicks in from February. |
The previous syntax was completely wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is built on #262.
It includes a Bash script to load all example scripts, and run them where possible (all scripts can be executed except tfvis.py).