Pep8 clean robust control #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c29e7cc to
ee37b8b
Compare
8d91a42 to
5be81d0
Compare
|
This PR has a mixture of PEP8 fixes and a new function. Can we refactor so that we just include the new functionality in this PR and leave the PEP8 fixes for later (see also discussion in closed PR #283). |
5be81d0 to
cf1bc91
Compare
cf1bc91 to
5eb82d1
Compare
|
Thank you for the review, the split is done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obsolete description, new PR for this: #289
I wanted to add this functionality to the library:
https://ch.mathworks.com/help/robust/ref/makeweight.html
Above the Matlab behavior, I added the possibility to compute higher orders weight functions.
The discrete behavior is not implemented yet as I don't know how to deal with it.
I tried the naive approach, creating the laplace variable as follows:
s = tf([1, 0], [1], Ts).However, the DC gain of the resulted weight function is not correct, as one could have expected.
If someone knows how to solve this problem, I would be glad to help him.
New description:
Pep8 cleaning of robust control, result of a split of the initial PR as asked by @murrayrm