Skip to content

install scikit-build for testing with slycot #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 26, 2019

Conversation

repagh
Copy link
Member

@repagh repagh commented Mar 19, 2019

We need scikit-build when building and testing with slycot, should solve the issue with PR #276

@repagh
Copy link
Member Author

repagh commented Mar 19, 2019

Why doesn't this build on Travis? More patience needed?

@repagh repagh closed this Mar 19, 2019
@repagh repagh reopened this Mar 19, 2019
@murrayrm
Copy link
Member

I tried this out on my version of the repository and as soon as I merged it into a branch that used to be calling Travis CI, it stopped running Travis CI tests.

It looks like the problem is that there is a parsing error. If I look at the request history on my local branch, I see the following error:

Could not parse murrayrm/python-control/.travis.yml@b35def48d67bbe27

@repagh
Copy link
Member Author

repagh commented Mar 25, 2019

@murrayrm : thanks for the hint!
That solved it.

@coveralls
Copy link

coveralls commented Mar 25, 2019

Coverage Status

Coverage remained the same at 78.383% when pulling 1453385 on repagh:install-scikit-for-travis into 31e6944 on python-control:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants