Added an initial version for step_info #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 similar comments
|
Looks good, including unit test. Will merge with 0.8.2 after checking to make sure there are no conflicts with other changes that need to be resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
failing on trying to follow some exercises of my control classes (that uses Matlab) I implemented this initial
step_infoversion (and a Matlab compatiblestepinfo) but because I don't have a licensed Matlab version I can't assert if everything is working nice.In testing, I just use an example from Matlab help docs for
stepinfoand added an arbiratry tolerance of 2%, is it acceptable?Thanks!