More unit tests #305
Merged
More unit tests #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a bunch of unit tests based on analysis of the coverage maps from coveralls.io. There are also some small fixes in the code for uncovered bugs and other small fixes:
Added a
reset_defaultsfunction inconfig.pyto allow configuration parameters to be reset to their initial values (used in unit testing).Changed the exceptions in
exceptions.pyto derive from appropriate exception types instead of the baseExceptionclass. Not really used, but seemed like a better way to allow people to catch exceptions using existing Python exception types.Small fixes in documentation as I found some inconsistencies.
A few things that aren't addressed:
Unit tests for some of the plotting functions (including
grid.py) are still low. These are tricky to capture in good unit tests, so I left them alone.There are lots of exceptions that are used for catching bad inputs. I started writing unit tests to cover those, but since they aren't functional code, I decided it wasn't critical.
These changes brought the coverage up to about 80% in my version. Will try to set that as a target going forward.