Return errors from examples/run_examples.sh correctly #311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes an error in
.travis.yml
that was not checking for errors inexamples/run_examples.sh
correctly, so any errors in the examples files were not being caught.Details: the original code used a command of the form
The
if
command returns the status of the last command, which in this case iscd ..
, which is always true. The fix uses the constructwhich still leaves the script in the main directory but returns the exit status of the bash command.