Skip to content

fix latex representation for exp format and multi-digit exponents of s or z #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 31, 2019
Merged

fix latex representation for exp format and multi-digit exponents of s or z #330

merged 6 commits into from
Dec 31, 2019

Conversation

bnavigator
Copy link
Contributor

quickfix for #278

@coveralls
Copy link

coveralls commented Jul 22, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 84.653% when pulling af08a30 on bnavigator:fix-latex into 4785145 on python-control:master.

@murrayrm
Copy link
Member

I think normal scientific notation uses \times instead of \cdot. Is there a reason not to use \times?

Also, scientific notation in Python uses a leading 0 and so 100 becomes 1e02 which becomes 10^{02}, which looks a bit odd. Can you strip the leading 0?

Also, not a huge deal, but might be nice to have some unit tests to verify this works correctly.

@bnavigator
Copy link
Contributor Author

Both seems to exist. See for example the documentation for the LaTeX siunitx package, page 28. I am used to \cdot, but maybe that's just more common here in Germany. How about having it configurable in the .config module and set \times as default?

@bnavigator
Copy link
Contributor Author

Coveralls is a mystery to me.

@murrayrm murrayrm added this to the 0.8.3 milestone Dec 31, 2019
@murrayrm murrayrm merged commit fe6d774 into python-control:master Dec 31, 2019
repagh pushed a commit to repagh/python-control that referenced this pull request Jun 9, 2020
@bnavigator @repagh
fix latex representation for exp format and multi-digit exponents of …
1860aeb 
…s or z (python-control#330)

* fix latex representation for exponential format and multi-digit exponents of s or z

* add docstring to _tf__string_to_latex

* move to times instead of cdot

* add unittest

* fix invalid escape sequence

* more invalid escape sequences
@bnavigator bnavigator deleted the fix-latex branch July 26, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.3
Development

Successfully merging this pull request may close these issues.
3 participants
@bnavigator @coveralls @murrayrm