Check for symmetric matrices with machine precision #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will always cause trouble since you are comparing floats which is the reason for such tricks. |
|
Why did coverage decrease? I specifically added a test! |
42f9a26 to
119ad47
Compare
|
Reviewed code and changes look good. Ran with updated Travis CI (see PR #353) and all tests past => ready to merge. |
repagh
pushed a commit
to repagh/python-control
that referenced
this pull request
Jun 9, 2020
* check for symmetric matrices with machine precision * mateqn_test array instead of deprecated matrix * test mateqn parameter checks * check for int first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tricks like
(Q + np.transpose(Q))/2to enforce a symmetric matrix like suggested in #347 should not be necessary.