Skip to content

added preliminary version of lqe function, which calculates the gain … #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 30, 2019
Merged

added preliminary version of lqe function, which calculates the gain … #351

merged 2 commits into from
Dec 30, 2019

Conversation

sawyerbfuller
Copy link
Contributor

…for a steady-state Kalman filter.

@coveralls
Copy link

coveralls commented Dec 10, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-7.8%) to 75.953% when pulling e312569 on sawyerbfuller:master into a4b4c43 on python-control:master.

@bnavigator
Copy link
Contributor

Travis CI fails on some jobs for two different reasons:

  • Python3.7 with slycot: missing symbol _dgebal. This has nothing to do with this PR and looks like a broken blas/lapack environment.

  • Python 2.7: Invalid syntax using the @ operator. Replace by numpy.dot() or wait until Python 2 support is dropped.

A unit test would not hurt.

@sawyerbfuller
Copy link
Contributor Author

Hi Ben, thanks for the suggestion. Added a unit test and python 2 compatibility

@murrayrm murrayrm added this to the 0.8.3 milestone Dec 29, 2019
@murrayrm
Copy link
Member

Travis CI is failing because of slycot issue addressed in PR #353. Checked via personal repository that all tests pass with that fix => ready to merge.

@murrayrm murrayrm merged commit 72262c6 into python-control:master Dec 30, 2019
@murrayrm murrayrm mentioned this pull request Jan 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.3
Development

Successfully merging this pull request may close these issues.
4 participants
@sawyerbfuller @coveralls @bnavigator @murrayrm