Skip to content

Fix iosys errors for unspecified # of inputs/outputs #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 31, 2019
Merged

Fix iosys errors for unspecified # of inputs/outputs #355

merged 2 commits into from
Dec 31, 2019

Conversation

murrayrm
Copy link
Member

Addresses the bug in issue #329 by fixing the __str__() method to handle the case where ninputs, noutputs, or nstates is None. Also added some unit tests.

Travis CI fails due to issues addressed in PR #353 (OK to merge).

@coveralls
Copy link

coveralls commented Dec 30, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-7.8%) to 76.006% when pulling 47112b4 on murrayrm:fix_iosys_none_errors into a4b4c43 on python-control:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-9.7%) to 74.053% when pulling 47112b4 on murrayrm:fix_iosys_none_errors into a4b4c43 on python-control:master.

@murrayrm murrayrm mentioned this pull request Dec 30, 2019
Closed
@murrayrm murrayrm added this to the 0.8.3 milestone Dec 31, 2019
@murrayrm murrayrm merged commit c36fcc0 into python-control:master Dec 31, 2019
@murrayrm murrayrm deleted the fix_iosys_none_errors branch December 31, 2019 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.3
Development

Successfully merging this pull request may close these issues.
2 participants
@murrayrm @coveralls