Complex matrices #372
Closed
Complex matrices #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murrayrm
reviewed
Feb 9, 2020
control/tests/statesp_test.py
Outdated
| @@ -21,15 +21,15 @@ def setUp(self): | |||
| """Set up a MIMO system to test operations on.""" | |||
|
|
|||
| # sys1: 3-states square system (2 inputs x 2 outputs) | |||
| A322 = [[-3., 4., 2.], | |||
| A322 = [[-3j, 4j, 2.], | |||
There was a problem hiding this comment.
Rather than rewrite an existing test to be complex, better to add a new test and leave the old test in place.
control/tests/statesp_test.py
Outdated
| @@ -117,20 +117,23 @@ def test_zero_siso(self): | |||
|
|
|||
| np.testing.assert_almost_equal(true_z, z) | |||
|
|
|||
| @unittest.skipIf(not slycot_check(), "slycot not installed") | |||
| # @unittest.skipIf(not slycot_check(), "slycot not installed") | |||
There was a problem hiding this comment.
Why comment this out? This will probably cause unit tests to fail when slycot is not installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to start to rewrite tests with complex matrices (issue #371) in a new branch. So far it seems that poles and zeros are calculated OK, but adding/subtracting/multiplying systems fails.
I've also commented out some "skip if slycot not installed"; some of these tests nonetheless run with sylicot uninstalled