-
Notifications
You must be signed in to change notification settings - Fork 438
Complex matrices #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Complex matrices #376
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
e6f2f60
allow _ssmatrix to accept complex values
lytex 53dbfe4
add new tests with complex state matrices
lytex 05d730a
rename to test_evalfr_complex, use self.sysC332
lytex a55165a
missed one sys.evalfr in previous commit
lytex 2d231a8
missed one sys.evalfr in previous commit
lytex f1c9b9e
add complex to test_freq_resp
lytex e7a93ea
remove warnings settings for debugging
lytex bb44827
ease precision of reference values in test
lytex fc5c76b
Merge branch 'master' into complex
lytex 5f58723
build an auxiliary system to compare against
lytex 1803d38
build an auxiliary system to compare against
lytex 84bc8ef
add code to use slycot complex function ab08nz if any matrix is complex
lytex File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really necessary? Why not just use
matrix()
andasarray()
withoutdtype
and figure out thedtype
later?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out if dtype is omitted completely, it could still be
int
and trip operations later on.The test suite already has complex casting warnings from Scipy and Slycot functions returning complex arrays (with 0 imaginary part), which are passed to
_ssmatrix
. Thus, my approach in #438 is to usedtype=np.result_type(np.float, arr)
, which ensures to cast from int to at least float and retains complex if arr is already complex.