Skip to content

Arrow head length and head width option is added in nyquist_plot function #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 18, 2020
Merged

Arrow head length and head width option is added in nyquist_plot function #379

merged 7 commits into from
Mar 18, 2020

Conversation

geekonloose
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Mar 4, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 84.599% when pulling 7c96781 on geekonloose:master into dab8ff6 on python-control:master.

@geekonloose geekonloose mentioned this pull request Mar 4, 2020
Closed
@murrayrm
Copy link
Member

murrayrm commented Mar 4, 2020

It looks like the line style or something changed so that every line in the is marked as deleted then added.

Can you try to reset the line style back to the original so that we can see only those lines that changed? Much easier to track updates that way.

@geekonloose
Copy link
Contributor Author

geekonloose commented Mar 5, 2020 •
edited
Loading

My editor was automatically formatting to pep8 format sorry for that. I have reformatted file as possible. I have checked with file compare in vs code (with the original file in python-control), it was able to show the changes. However, GitHub is showing so many deletions. If you want, I can provide line-numbers where I have made changes.

@murrayrm
Copy link
Member

murrayrm commented Mar 5, 2020

Can you just go back to the original file and only edit the lines that actually need to be changed? Just putting the lines changed in the PR comments won't let people see what actually changed if they do git diff.

@murrayrm
Copy link
Member

murrayrm commented Mar 5, 2020

Looks like 8f8565b fixed the problem but then 1f4885d changed it back?

@murrayrm
Copy link
Member

murrayrm commented Mar 5, 2020

Also: I suggest using keywords that are more descriptive than hw and hl. How about arrowhead_width and arrowhead_length?

@geekonloose
Copy link
Contributor Author

ok I will do that.

@murrayrm murrayrm merged commit 874d52e into python-control:master Mar 18, 2020
@murrayrm murrayrm mentioned this pull request Mar 18, 2020
Closed
repagh pushed a commit to repagh/python-control that referenced this pull request Jun 9, 2020
@geekonloose @repagh
Arrow head length and head width option is added in nyquist_plot func…
84e37f5 
…tion (python-control#379)

Add option to change Nyquist plot arrow size:
* Nyquist_plot changed to accommodate arrow size
* color option is added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geekonloose @coveralls @murrayrm