add capability to switch to legacy defaults #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes look good. I think the docstrings for the various functions need to be updated to indicate the default values come from config variables. We should also add the new variables to the documentation in |
…ng new config parameters default_dt and remove_useless_states
|
Looks ready to merge. Will let sit for a few days in case others want to comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example,
config.use_legacy_defaults('0.8.3')I added a few more defaults that might change in the future, but left them as they currently are for this PR:
* statesp.remove_useless_states (issue #244) (currently True; future is False? )
* statesp and xferfcn.default_dt (issue #422) (currently None, future is 0?)
* statesp.use_numpy_matrix (currently True, future is False)