Skip to content

Extend returnScipySignalLTI() to discrete systems #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 29, 2020
Merged

Extend returnScipySignalLTI() to discrete systems #445

merged 1 commit into from
Dec 29, 2020

Conversation

bnavigator
Copy link
Contributor

@bnavigator bnavigator commented Aug 2, 2020 •
edited
Loading

These were not covered by the tests, so I wrote some tests and found out it is not that hard to extend them to discrete systems.

@coveralls
Copy link

coveralls commented Aug 2, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 86.618% when pulling d6d77dc on bnavigator:extend-tf2scipylti into 26206dc on python-control:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 84.489% when pulling a8aa41e on bnavigator:extend-tf2scipylti into d3142ff on python-control:master.

@bnavigator bnavigator mentioned this pull request Aug 2, 2020
Merged
@bnavigator bnavigator added this to the 0.9.0 milestone Aug 16, 2020
@sawyerbfuller
Copy link
Contributor

Returning a cont-time scipy system when dt=None seems like a reasonable choice (I think in scipy, dt=None actually means cont time).

sawyerbfuller
sawyerbfuller approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@sawyerbfuller sawyerbfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@bnavigator
Copy link
Contributor Author

Re current CI fail: #456

@bnavigator bnavigator merged commit 51c797e into python-control:master Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sawyerbfuller sawyerbfuller sawyerbfuller approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bnavigator @coveralls @sawyerbfuller