Skip to content

Fix lqe docstring and input array type #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 30, 2020
Merged

Fix lqe docstring and input array type #483

merged 2 commits into from
Dec 30, 2020

Conversation

bnavigator
Copy link
Contributor

Fix the return variable of lqe docstring. Allow placeable poles to be any array_like input.

Outsourced from #438, because it is not directly related to the test suite

@coveralls
Copy link

coveralls commented Dec 29, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.003%) to 86.616% when pulling 5a9e433 on bnavigator:statefbk-input-doc into 51c797e on python-control:master.

@murrayrm
Copy link
Member

This change looks fine, but perhaps we should update docstring and argument processing on acker to match?

@bnavigator
Copy link
Contributor Author

Do you mean the poles input for acker? It processes them through np.poly and thus already accepts array_like.

@bnavigator
Copy link
Contributor Author

Merging, this is needed for #438

@bnavigator bnavigator merged commit f998a20 into python-control:master Dec 30, 2020
@bnavigator bnavigator deleted the statefbk-input-doc branch January 5, 2021 20:13
@murrayrm murrayrm added this to the 0.9.0 milestone Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bnavigator @coveralls @murrayrm