Skip to content

handle empty pole vector for timevector calculation #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2020
Merged

handle empty pole vector for timevector calculation #485

merged 1 commit into from
Dec 30, 2020

Conversation

bnavigator
Copy link
Contributor

@bnavigator bnavigator mentioned this pull request Dec 30, 2020
Merged
@coveralls
Copy link

coveralls commented Dec 30, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 86.621% when pulling 1603e85 on bnavigator:timevector-fix into 51c797e on python-control:master.

@bnavigator bnavigator mentioned this pull request Dec 30, 2020
Closed
murrayrm
murrayrm approved these changes Dec 30, 2020
View reviewed changes
Copy link
Member

@murrayrm murrayrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks fine. The code itself could use some documentation and the reuse of m_u as a subset of p_u is confusing, but not something that needs to be fixed here.

@murrayrm murrayrm merged commit 4eee1f3 into python-control:master Dec 30, 2020
@bnavigator bnavigator deleted the timevector-fix branch January 5, 2021 20:18
@murrayrm murrayrm added this to the 0.9.0 milestone Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murrayrm murrayrm murrayrm approved these changes

@sawyerbfuller sawyerbfuller Awaiting requested review from sawyerbfuller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bnavigator @coveralls @murrayrm