deprecate np.matrix usage #486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#438 will handle the CI fail: The warning category changed. |
murrayrm
approved these changes
Dec 30, 2020
|
Assume it's OK to change tests to use |
|
You might want to have a look at #438 and wait until that is merged before making changes to tests (they are undergoing significant refactoring). We are waiting on CI tests to run, but merges should happen today. |
f9d4a9c to
1565097
Compare
|
Now that #438 is merged, this passes. But with removing the filter as discussed #438 (comment) it seems that the actual new default is not set properly during the test suite run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As previously discussed and announced: 0.9 deprecates np.matrix usage