Fix loading of defaults during pytest fixture setup #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make matarrayout and matarrayin function scoped fixtures so that they can set the warnings filters individually as needed for each test.
|
I'm not enough of a pytest guru (yet -:) to understand this in detail. OK by me to merge unless you feel that someone else should have a closer look first. |
|
I think I tested it thoroughly on my local machine. Given that it affects only the test suite and not the end user I feel confident enough to merge it with "just" your OK. |
|
Meh, the 3 uncovered lines in freqplot need some investigation before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make matarrayout and matarrayin function scoped fixtures so
that they can set the warnings filters individually as needed for
each test.
Fixes #488