-
Notifications
You must be signed in to change notification settings - Fork 438
I/O system improvements: linearize, interconnect, docstrings #497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
murrayrm
merged 12 commits into
python-control:master
from
murrayrm:linearize_named_signals
Jan 5, 2021
Merged
I/O system improvements: linearize, interconnect, docstrings #497
murrayrm
merged 12 commits into
python-control:master
from
murrayrm:linearize_named_signals
Jan 5, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnavigator
reviewed
Jan 4, 2021
18ffe2e
to
488edf5
Compare
https://travis-ci.org/github/python-control/python-control/jobs/752920076#L2029
Autouse fixture |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a couple of enhancements for the I/O systems package, mainly related to linear systems:
The
linearize
command now preserves signal names for the linearized system, so that you can use signal names when forming andInterconnectedSystem
.Interconnections of
LinearIOSystem
s are now treated asLinearICSystems
(a subclass ofInterconnectedSystem
andLinearIOSystem
) so thatStateSpace
functions will still work on them and they still keep track of the underlying interconnection structure.There is now an
interconnect
function that allows the construction of anLinearICSystems
or aInterconnectedSystem
depending on whether the subsystems are all linear or not. This basically serves as a replacement for theconnect
function for LTI systems and allows named interconnection of linear or nonlinear systems.In addition, I cleaned up the description for how to specify interconnections so that tuples are only used for the lowest level signal descriptions; everything else is a list. (Tuples will still work, but there are some ambiguities when you use tuples since
outlist=(3, 2, 1)
could be interpreted as a signal description for a single signal (subsystem 3, signal 2, with gain 1) or as a list of signals for SISO systems (the single outputs from subsystems 3, 2, and 1).Additional small changes:
The
rss
anddrss
functions now allow thestrictly_proper
keyword, which sets the D matrix to zero. (I needed this to avoid occasional errors in unit tests for theinterconnect
function.Added some configuration variables that allow you to change the way that states in interconnected systems are named (default was
sys.state
but issys_state
for 0.9+) and the way that duplicate systems are named (default wascopy of sys
but issys$copy
for 0.9+).Added unit tests for all of the above.
Updated examples to match the newly documented conventions for signal list specification.