Skip to content

REBASE: use __call__ instead of evalfr in lti system classes #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

murrayrm
Copy link
Member

@murrayrm murrayrm commented Jan 6, 2021

This is a rebase of PR #449.

@murrayrm
Copy link
Member Author

murrayrm commented Jan 6, 2021

Requesting a second look from @bnavigator, @sawyerbfuller just to make sure it all still looks OK. Will merge as soon as they approve.

@bnavigator
Copy link
Contributor

bnavigator commented Jan 6, 2021

The change for frd_test.py::test_eval() got lost.

Fix in 73fc6a6

@bnavigator
Copy link
Contributor

@sawyerbfuller are you okay with this single commit squashing all your contributions? Otherwise you could merge (not pick!) the commit into your origin:call-method. (See sawyerbfuller#1 (comment))

Let's also wait on Travis. The scheduler is particularly slow today.

@coveralls
Copy link

coveralls commented Jan 6, 2021

Coverage Status

Coverage decreased (-0.2%) to 87.32% when pulling 195bec3 on murrayrm:call-method_rebase into 4103688 on python-control:master.

@bnavigator
Copy link
Contributor

I pushed your rebase into #449. We can continue discussion in the original PR.

@bnavigator bnavigator closed this Jan 6, 2021
@murrayrm
Copy link
Member Author

murrayrm commented Jan 6, 2021

Thanks, @bnavigator.

@sawyerbfuller
Copy link
Contributor

@sawyerbfuller are you okay with this single commit squashing all your contributions? Otherwise you could merge (not pick!) the commit into your origin:call-method.

is this still relevant now that #449 is now (mostly) rebased?

@bnavigator
Copy link
Contributor

I addressed all my comments and pushed into your branch. Even with your small edit in between. Hooray for git 😀

@murrayrm murrayrm deleted the call-method_rebase branch January 14, 2021 07:05
@murrayrm murrayrm modified the milestone: 0.9.0 Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants