-
Notifications
You must be signed in to change notification settings - Fork 438
REBASE: use __call__ instead of evalfr in lti system classes #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Requesting a second look from @bnavigator, @sawyerbfuller just to make sure it all still looks OK. Will merge as soon as they approve. |
The change for frd_test.py::test_eval() got lost. Fix in 73fc6a6 |
@sawyerbfuller are you okay with this single commit squashing all your contributions? Otherwise you could merge (not pick!) the commit into your origin:call-method. (See sawyerbfuller#1 (comment)) Let's also wait on Travis. The scheduler is particularly slow today. |
I pushed your rebase into #449. We can continue discussion in the original PR. |
Thanks, @bnavigator. |
is this still relevant now that #449 is now (mostly) rebased? |
I addressed all my comments and pushed into your branch. Even with your small edit in between. Hooray for git 😀 |
This is a rebase of PR #449.