fix rlocus plotting problem in Jupyter notebooks + comments, PEP8 #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Could you post before-after pictures here? The coveralls increase by 11% is a lie, because the last Travis run on master failed with server errors. Uncovered line: https://coveralls.io/builds/36205925/source?filename=control%2Frlocus.py#L247. At least call the plot function with a dtime sys once? Maybe https://matplotlib.org/devel/testing.html#writing-an-image-comparison-test is also worth a try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #464. I added some comments to the code along the way as I was trying to sort out what was going wrong. No easy unit tests for this one, I think, since it seems like the issue is restricted to Jupyter notebooks and has to do with the way they generate plots (I guess).
Before (need to zoom way in to see the plot)
After:
