change default value of statesp.remove_useless_states to False #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sawyerbfuller
approved these changes
Jan 15, 2021
bnavigator
reviewed
Jan 15, 2021
| @@ -395,9 +395,6 @@ def test_is_static_gain(self): | |||
| D0 = 0 | |||
| D1 = np.ones((2,1)) | |||
| assert StateSpace(A0, B0, C1, D1).is_static_gain() | |||
| # TODO: fix this once remove_useless_states is false by default | |||
| # should be False when remove_useless is false | |||
| # print(StateSpace(A1, B0, C1, D1).is_static_gain()) | |||
There was a problem hiding this comment.
assert not StateSpace(A1, B0, C1, D1).is_static_gain() ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #244. It looks like the only issue was that converting a constant to a state space object was creating an extra state and this state had to then be removed. By creating a state space system with no internal state (A = [[]] instead of A=[[0]]), this action is no longer required to get sensible results from block diagram algebra functions.
The PR makes that change and also changes the default value of
statesp.remove_useless_statestoFalse.