Freqplot improvements #522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… an empty glyph (on mac)
…mented in a few places
…lt of 50 for logspace; unify frequency range specification for bode and nyquist
… an empty glyph (on mac)
…mented in a few places
…lt of 50 for logspace; unify frequency range specification for bode and nyquist
…ler/python-control into freqplot-improvements
…be unneccesary and to avoid a merge conbflict with python-control#521
|
added a commit because changes were not necessary and to avoid a merge conflict with #521 |
sawyerbfuller
commented
Jan 29, 2021
sawyerbfuller
commented
Jan 29, 2021
sawyerbfuller
commented
Jan 29, 2021
| @@ -78,8 +78,8 @@ def test_sisotool(self, sys): | |||
|
|
|||
| # Check if the bode_mag line has moved | |||
| bode_mag_moved = np.array( | |||
| [111.83321224, 92.29238035, 76.02822315, 62.46884113, 51.14108703, | |||
| 41.6554004, 33.69409534, 27.00237344, 21.38086717, 16.67791585]) | |||
| [674.0242, 667.8354, 661.7033, 655.6275, 649.6074, 643.6426, | |||
There was a problem hiding this comment.
Had to Change this because new number of sampling points.
murrayrm
reviewed
Jan 29, 2021
…nience eg legend(('sys1','sys2'))
…ler/python-control into freqplot-improvements merge!
murrayrm
approved these changes
Jan 31, 2021
This was referenced Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes to freqplot.py:
edit:
legend(('sys1', 'sys2'))