Skip to content

I/O system updates #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 9, 2021
Merged

I/O system updates #536

merged 2 commits into from
Feb 9, 2021

Conversation

murrayrm
Copy link
Member

@murrayrm murrayrm commented Feb 7, 2021

Addresses issue #530:

  • Automatic summation and splitting for implicit signal connections fixed.
  • The inplist and outlist can how be omitted if you are using automatic signal names by using inputs and outputs to list signal names that appear in the list of subsystems to be connected.
  • For easier readability, input and output can be used in place of inputs and outputs.

Combined, these changes allow the following simplified commands for interconnecting systems via signal names:

    P = ct.tf2io(ct.tf(1, [1, 0]), input='u', output='y')
    C = ct.tf2io(ct.tf(10, [1, 1]), input='e', output='u')
    sumblk = ct.summing_junction(inputs=['r', '-y'], output='e')
    T = ct.interconnect((P, C, sumblk), input='r', output='y')

@murrayrm murrayrm linked an issue Feb 7, 2021 that may be closed by this pull request
new iosys.interconnect is great, but... #530
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 87.743% when pulling 2538a06 on murrayrm:iosys_updates into d75c395 on python-control:master.

sawyerbfuller
sawyerbfuller reviewed Feb 9, 2021
View reviewed changes
control/iosys.py
super(NonlinearIOSystem, self).__init__(
inputs=inputs, outputs=outputs, states=states,
params=params, dt=dt, name=name
)

# Make sure all input arguments got parsed
if kwargs:
raise TypeError("unknown parameters %s" % kwargs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤙

@sawyerbfuller sawyerbfuller merged commit 2c132c9 into python-control:master Feb 9, 2021
@sawyerbfuller
Copy link
Contributor

After merging the master branch is now failing tests - perhaps a conflict with the new describing functions system.

I'm not quite able to tell what is going on. In descfcn_test.py I tried changing instantiations of ct.NonlinearIOSystem(None, ... , input=1, output=1) and similar, replacing input with inputs. But when I run pytest locally, another error appears in _process_time_response() @murrayrm any ideas?

@murrayrm
Copy link
Member Author

Looks like something went wrong in the merge. I'll have a look tonight.

@murrayrm murrayrm mentioned this pull request Feb 11, 2021
Merged
@murrayrm murrayrm deleted the iosys_updates branch February 11, 2021 06:15
@sawyerbfuller
Copy link
Contributor

Just a quick update: I've put the new auto-summing and auto-splitting, and general interconnect features to use. I've used them to make quite complex feedback systems with any topology I want. In particular, I was able to create software in a few tens of lines of codes that allows me to perform a root locus gain selection -- and plot the step response in SISOTOOL -- for all three gains in a PID controller independently. This entailed an interconnection of about ten subsystems.

@murrayrm murrayrm added this to the 0.9.0 milestone Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sawyerbfuller sawyerbfuller sawyerbfuller left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

new iosys.interconnect is great, but...
3 participants
@murrayrm @coveralls @sawyerbfuller