Skip to content

new method keyword in stability_margins and auto-fallback back to FRD .. #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 17, 2021

Conversation

sawyerbfuller
Copy link
Contributor

... when it is detected that there may be numerical inaccuracy in dt polynomial calculation.

  • this is intended to resolve numerical issue observed in DT margin calculation when there is a large difference between the size of numerator and denominator coefficients stability_margins doesn't find gain=1 crossover frequency correctly for DT systems #523. I am not sure how good the method is I used to detect this issue is any good. In fact I am sure it is not. comments welcome here.
  • can use method='poly' to override and force polynomial evaluation, or method='FRD' to force to using interpolated FRD to calculate gain and phase crossover frequencies.

…ical inaccuracy in dt polynomial calculation
@coveralls
Copy link

coveralls commented Mar 12, 2021

Coverage Status

Coverage increased (+0.06%) to 88.885% when pulling 72cb23f on sawyerbfuller:frd-margin into 0f951e1 on python-control:master.

@murrayrm
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stability_margins doesn't find gain=1 crossover frequency correctly for DT systems
4 participants