support discrete system as input for FRD #568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
... needs unit tests. |
sawyerbfuller
approved these changes
Mar 12, 2021
There was a problem hiding this comment.
Looks good to me! One remark: FRD.__call__ only works with purely imaginary arguments of the form omega*1j, which I think is still what we want, right? The alternative is if an FRD system derived from a discrete time system that z must be on the unit circle. I think I favor the former but I am not positive that is the "right" way or not.
sawyerbfuller
added a commit
to sawyerbfuller/python-control
that referenced
this pull request
Mar 12, 2021
|
I also favor the current. Otherwise you would have to keep track from which kind you created the FRD system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggered by #566 and #523, it was revealed that the evaluation of the sys parameter does not take into account discrete time systems.