Step info improve jpp #583
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now can compute the step response characteristics for MIMO systems. Fix undershoot caculus for sistems with negative response.
and add a working example too, finaly I corrected the see also to referring to functions of this library
|
Your commits have a date from 2 days ago and they are based on an older commit. Please check #577, which is already merged. We essentially did very similar changes. Could you have a look and make further improvements such as the undershoot calculation based on current master please? You can discard your unit tests and just change the existing references for the undershoot value, if necessary. |
|
ok, Ill try to solve this problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: @bnavigator check this new feature... I tested it with a mimo system from matlab help online. This new version improve the undershoot calculus. The undershoot ocurr when the value have diferent sign respect the y_final... the system must have inverse response
For discusions:
TODO (WIP): make a new function to compute step_info for data from external simulations or stimulations: step_info_data(t,y,y_final)