Skip to content

Change step_info undershoot percentage calculation #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 25, 2021
Merged

Change step_info undershoot percentage calculation #590

merged 5 commits into from
Mar 25, 2021

Conversation

juanodecc
Copy link
Contributor

Improper systems with negative respose, if do not have inverse
respons, the undershoot must be 0.
This ocurr in the MIMO system used in the step_info test.
I think, the rise time and setting minimun and maximun computed
by this funtion are right in.

@juanodecc
Solved undershoot value calculus problem.
a95f75f 
Improper systems with negative respose, if do not have inverse
respons, the undershoot must be 0.
This ocurr in the MIMO system used in the step_info test.
I think, the rise time and setting minimun and maximun computed
by this funtion are right in.
@coveralls
Copy link

coveralls commented Mar 24, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 89.221% when pulling 14a92fe on juanodecc:step_info_improve_undershoot into 203cae8 on python-control:master.

bnavigator
bnavigator reviewed Mar 24, 2021
View reviewed changes
juanodecc
juanodecc commented Mar 24, 2021
View reviewed changes
Copy link
Contributor Author

@juanodecc juanodecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok... now I see

@juanodecc
Copy link
Contributor Author

@bnavigator can you check it. Tank

bnavigator
bnavigator reviewed Mar 25, 2021
View reviewed changes
@bnavigator bnavigator changed the title Undershoot value calculus problem. Solved Change step_info undershoot percentage calculation Mar 25, 2021
@bnavigator bnavigator force-pushed the step_info_improve_undershoot branch from b957dee to 14a92fe Compare March 25, 2021 00:27
@bnavigator
Copy link
Contributor

I pushed some style cleanups and a I think I have a cleaner formula for the undershoot. Please check.

sawyerbfuller
sawyerbfuller approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@sawyerbfuller sawyerbfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. removed one array search - > faster - > good

@bnavigator bnavigator merged commit ce4c2b6 into python-control:master Mar 25, 2021
@bnavigator
Copy link
Contributor

Thanks @juanodecc

@murrayrm murrayrm added this to the 0.9.1 milestone Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnavigator bnavigator bnavigator left review comments

@sawyerbfuller sawyerbfuller sawyerbfuller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.
5 participants
@juanodecc @coveralls @bnavigator @sawyerbfuller @murrayrm