Skip to content

Include InfValue into settling min/max calculation for step_info #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 1, 2021
Merged

Include InfValue into settling min/max calculation for step_info #600

merged 3 commits into from
Apr 1, 2021

Conversation

bnavigator
Copy link
Contributor

Fixes #598

@bnavigator
Copy link
Contributor Author

The flaky markov test failure is really annoying. #588 will fix it. Also, #588 will make a rebase of this one necessary, or vice versa.

juanodecc
juanodecc reviewed Mar 30, 2021
View reviewed changes
Copy link
Contributor

@juanodecc juanodecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.274% when pulling e06197c on bnavigator:fix-598 into 8b900ca on python-control:master.

@bnavigator bnavigator merged commit f1a9860 into python-control:master Apr 1, 2021
@murrayrm murrayrm added this to the 0.9.1 milestone Dec 30, 2021
@bnavigator bnavigator deleted the fix-598 branch February 18, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanodecc juanodecc juanodecc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.

This system broke step_info function test
4 participants
@bnavigator @coveralls @juanodecc @murrayrm