Skip to content

add DefaultDict for deprecation handling #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 1, 2021
Merged

add DefaultDict for deprecation handling #619

merged 3 commits into from
May 1, 2021

Conversation

bnavigator
Copy link
Contributor

As discussed here: #593 (comment)

@coveralls
Copy link

coveralls commented Apr 29, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 89.63% when pulling e0dab93 on bnavigator:defaults-deprecation into db174b7 on python-control:master.

@bnavigator bnavigator force-pushed the defaults-deprecation branch from 0ccf0a6 to 21ef29e Compare April 29, 2021 20:35
roryyorke
roryyorke reviewed May 1, 2021
View reviewed changes
Copy link
Contributor

@roryyorke roryyorke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea seems good, see comments on implementation above.

A very brief docstring or comment explaining that DefaultDict is for deprecation might be good.

@roryyorke
Copy link
Contributor

LGTM

@bnavigator
Copy link
Contributor Author

Thank you for the review @roryyorke!

@bnavigator bnavigator merged commit 9f27293 into python-control:master May 1, 2021
@murrayrm murrayrm added this to the 0.9.1 milestone Dec 30, 2021
@bnavigator bnavigator deleted the defaults-deprecation branch February 18, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roryyorke roryyorke roryyorke left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.
4 participants
@bnavigator @coveralls @roryyorke @murrayrm