fix damp method for discrete time systems with a negative real-valued pole #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gative real-valued pole
bnavigator
reviewed
Aug 17, 2021
bnavigator
reviewed
Aug 17, 2021
bnavigator
reviewed
Aug 17, 2021
bnavigator
reviewed
Aug 17, 2021
bnavigator
approved these changes
Aug 18, 2021
|
Thank you! |
|
Thank you for your advices @bnavigator ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(first pull request on GitHub)
When a discrete time system has a real-valued negative pole, the discrete to continuous conversion using the log function returns nan. Then, the damp method is not able to compute the damping and the wn values.
To avoid this problem, the poles must be cast to complex values (https://numpy.org/doc/stable/reference/generated/numpy.log.html)