Skip to content

FIX: plot Nyquist frequency correctly in Bode plot in Hz #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

murrayrm
Copy link
Member

@murrayrm murrayrm commented Sep 6, 2021

Quick fix for issue #650, using solution from @dc5048.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.923% when pulling 3b90050 on murrayrm:fix_bode_nyquist_hz into 18976c1 on python-control:master.

@bnavigator
Copy link
Contributor

For reference:

import control
tf1 = control.tf(control.drss(3,1,1))
tf1.dt=0.1
control.bode_plot(tf1, Hz=True)
Before After
pr-651-pre pr-651-post

(Two different random discrete transfer functions)

@bnavigator bnavigator merged commit 5ab0a1c into python-control:master Sep 6, 2021
@bnavigator bnavigator linked an issue Sep 6, 2021 that may be closed by this pull request
@murrayrm murrayrm deleted the fix_bode_nyquist_hz branch November 27, 2021 18:35
@murrayrm murrayrm added this to the 0.9.1 milestone Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discrete system bode_plot nyquist line does not respect Hz parameter
3 participants