-
Notifications
You must be signed in to change notification settings - Fork 438
new Pid design function built on sisotool #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bnavigator
merged 10 commits into
python-control:master
from
sawyerbfuller:pid-designer
Dec 26, 2021
Merged
new Pid design function built on sisotool #662
bnavigator
merged 10 commits into
python-control:master
from
sawyerbfuller:pid-designer
Dec 26, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnavigator
reviewed
Nov 2, 2021
45f3555
to
fa1dea1
Compare
1eb9997
to
b2478f2
Compare
…-changing colors in sisotool
…tial gain to 1, new noplot argument for faster testing
ee1aa5e
to
4ee9fd1
Compare
FYI: this is generating a bunch of warning messages. We should clean up when we get a chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a manual means of tuning a PID controller but does not attempt an automatic solution, thus its name
pid_designer
. Edit: renamed function torootlocus_pid_designer
to distinguish it from loopshaping techniques. Partially addresses #657.Uses
Sisotool
to investigate the effect of adding or subtracting anamount
deltaK
to the proportional, integral, or derivative (PID) gains ofa controller. One of the PID gains,
Kp
,Ki
, orKd
, respectively, canbe modified at a time.
Sisotool
plots the step response, frequencyresponse, and root locus.
When first run,
deltaK
is set to 0; click on a branch of the root locusplot to try a different value. Each click updates plots and prints
the corresponding
deltaK
. To tune all three PID gains, repeatedly callpid_designer
, and select a differentgain
each time ('P'
,'I'
,or
'D'
). Make sure to add the resultingdeltaK
to your chosen initialgain on the next iteration.