Skip to content

modify discrete-time contour for nyquist plots to indent around poles #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2021
Merged

modify discrete-time contour for nyquist plots to indent around poles #668

merged 2 commits into from
Nov 5, 2021

Conversation

sawyerbfuller
Copy link
Contributor

@sawyerbfuller sawyerbfuller commented Nov 5, 2021 •
edited
Loading

Completing a “todo” that was in the code, to make nyquist plots work better foe discrete-time systems (Continuous-time indentation was already in place )

@sawyerbfuller sawyerbfuller marked this pull request as draft November 5, 2021 06:50
@coveralls
Copy link

coveralls commented Nov 5, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 89.945% when pulling a948186 on sawyerbfuller:nyquist-discrete-indent into e9c224c on python-control:master.

@sawyerbfuller
z-to-s plane mapping results in small numerical errors so assume s-pl…
a948186 
…ane poles near imaginary axis are on imaginary axis
@sawyerbfuller sawyerbfuller marked this pull request as ready for review November 5, 2021 19:02
@sawyerbfuller sawyerbfuller changed the title modify discrete-time contour for nyquist plots to indent around poles [WIP] modify discrete-time contour for nyquist plots to indent around poles Nov 5, 2021
bnavigator
bnavigator approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@bnavigator bnavigator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sawyerbfuller sawyerbfuller merged commit affe4d3 into python-control:master Nov 5, 2021
@murrayrm murrayrm added this to the 0.9.1 milestone Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnavigator bnavigator bnavigator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.
4 participants
@sawyerbfuller @coveralls @bnavigator @murrayrm