Skip to content

Remove duplicate Slycot error handling, require Slycot >=0.4 #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2021
Merged

Remove duplicate Slycot error handling, require Slycot >=0.4 #678

merged 1 commit into from
Dec 4, 2021

Conversation

bnavigator
Copy link
Contributor

There is a lot of unused code in mateqn.py, because Slycot itself warns and raises its own exceptions in case of invalid inputs or failing numerical routines.

I guess this also overlaps a bit with #670.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.5%) to 92.716% when pulling af4c51d on bnavigator:slycot-handling into 81a4f38 on python-control:master.

@murrayrm
Copy link
Member

murrayrm commented Dec 4, 2021

LGTM.

@bnavigator
Copy link
Contributor Author

Thanks.

@bnavigator bnavigator merged commit c2f6f8a into python-control:master Dec 4, 2021
@murrayrm murrayrm added this to the 0.9.1 milestone Dec 30, 2021
@bnavigator bnavigator mentioned this pull request Jan 22, 2024
Closed
@bnavigator bnavigator deleted the slycot-handling branch February 18, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.
3 participants
@bnavigator @coveralls @murrayrm