bode-plot #69
Merged
bode-plot #69
+9,128
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added sharing of x axis (magnitude and phase are zoom and pan together) * added an option to * added manual test / example
Optimizing bode-plot.
discrete systems to be conform with existing tests (/control/tests/discrete_test.py). But the question remains: What distance to the Nyquist frequency is appropriate?
| @@ -60,7 +58,7 @@ | |||
| # | |||
|
|
|||
| # Bode plot | |||
| def bode_plot(syslist, omega=None, dB=None, Hz=None, deg=None, | |||
| def bode_plot(syslist, omega=None, omega_num=None, dB=None, Hz=None, deg=None, | |||
There was a problem hiding this comment.
if backward compatibility is important, omega_num should go just before *args
…ng omega to define a frequency interval a new argument omega_limits has
|
Looked through changes and these look good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #49: some notes are implemented
issue #50: considered in example