Skip to content

added binder link #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2022
Merged

added binder link #693

merged 1 commit into from
May 25, 2022

Conversation

jonititan
Copy link
Contributor

No description provided.

@sawyerbfuller
Copy link
Contributor

I thought this PR was pretty opaque but then I found this similar PR in slycot: python-control/Slycot#168. Anybody else here have experience with this service? Seems on the surface to be an easy way to try things out.

@sawyerbfuller
Copy link
Contributor

Did a little bit of background research - Fernando Perez' (creator of iPython/Jupyter) has a link to the Binder service on a page he runs for a grant from the NSF he got in part to fund development of Jupyter, so it seems legit to me.

Proposed location for the link in the python-control docs seems reasonable as a way to 'try' the library.

I did a brief test and it works: I was able to quickly plot a step response. It appears that slycot does not currently work. Given that there is still a lot of functionality in the library even without slycot, and that this feature seems useful enough, I've merged it. Thanks @jonititan !

@sawyerbfuller sawyerbfuller merged commit 865ba02 into python-control:master May 25, 2022
@jonititan
Copy link
Contributor Author

Glad I could be of assistance.
Binder is a really useful idea for introducing new libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants