Skip to content

Signed-off-by: whiplash01 <amirhasandex@gmail.com> #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

whiplash01
Copy link

Updated the gm and wg values

Faulty values were failing the tests, This commit fixes it.

Updated the gm and wg values

Faulty values were failing the tests, This commit fixes it.
@roryyorke
Copy link
Contributor

I don't think the patch is right; testCombi01 passes fine on master 49045ca [1], and that's on Python 2.7, 3.3, and 3.4.

The numbers you've used look odd; a GM of 1e-15 at a frequency of 1e-9 seems implausible.

It might be there's a bug lurking in the margin code. What OS, Python, Numpy, and slycot version did you use to test this? (Can't recall offhand if slycot code is used in the margin calcs---probably not).

[1] https://travis-ci.org/python-control/python-control/builds/90145794

@whiplash01
Copy link
Author

@roryyorke Thanks for responding. When I was installing python-control, I was having this error on Gm and Wg values which on terminal appeared as this should be this. I replaced the values and all the tests ran fine. It worked. I am not a control engineering expert, so I can't determine whether the values I have selected are even in the ballpark. Therefore, I concluded it was a bug.

OS - Ubuntu 14.04 LTS
Python - 2.7
NumPy - 1.8.2
Slycot - Can't determine.

Some help would be appreciated.

@roryyorke
Copy link
Contributor

unfortunately I'll be offline for about a week.

I am using Ubuntu 14.04 and Python 2.7 as well.

I can only give general advice now: use virtualenv, try miniconda, and look
at the .travis.xml file for hints on how the dependencies are installed.
On 21 Dec 2015 20:45, "Mohd Amir Hasan Khan" notifications@github.com
wrote:

@roryyorke https://github.com/roryyorke Thanks for responding. When I
was installing python-control, I was having this error on Gm and Wg values
which on terminal appeared as this should be this. I replaced the values
and all the tests ran fine. It worked. I am not a control engineering
expert, so I can't determine whether the values I have selected are even in
the ballpark. Therefore, I concluded it was a bug.

OS - Ubuntu 14.04 LTS
Python - 2.7
NumPy - 1.8.2
Slycot - Can't determine.

Some help would be appreciated.


Reply to this email directly or view it on GitHub
#70 (comment)
.

@whiplash01
Copy link
Author

Thanks, I'll check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants