-
Notifications
You must be signed in to change notification settings - Fork 438
Passivity indices and support for discrete time systems. #750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passivity indices and support for discrete time systems. #750
Conversation
my source for the algorithm only considers square, minimal systems.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
@bnavigator I've split get_passivity_index() into get_output_fb_index() and get_input_ff_index(). I've also removed all the weird conditionals in ispassive(), it just has one code path now. I kept all the nu's and rho's in _solve_passivity_LMI() because it's easier to match the syntax from the source paper that way IMO. |
It looks like the passivity module is not (yet) loaded in Other than that, looks ready to go? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More small things to fix (sorry I didn't notice these on my previous pass..).
Add more detailed and clear comments and doc strings. Fix correctness of _solve_passivity_LMI for inputing values for both input and output passivity indices. Allow checking of passivity using ispassive given values for input and ouput passivity indices.
Add even more detail to doc strings.
… instead of -inf when infeasible. (I'm not sure how to trigger this code for unit testing, mostly a just-in-case.
Is there a name for what this is? |
"longstring stringliteral with raw stringprefix" or "raw triple-quoted strings"
|
Noice |
@Mark-Yeatman @bnavigator This looks like it is ready to merge? Anything else planned? |
Thanks @Mark-Yeatman! Looking forward to future pull request with further enhancements of this module. |
This adds support for input and output passivity indices and "is passive or not" for discrete time systems.